Skip to content

[python]-setuptools-GHSA-r9hx-vwmv-q579-remove setuptools-65.5.0-py3-none-any.whl - #866

Merged
Samruddhi Khandale (samruddhikhandale) merged 6 commits into
devcontainers:mainfrom
gauravsaini04:python_setuptools_65.5.0_GHSA-r9hx-vwmv-q579
Feb 22, 2024
Merged

[python]-setuptools-GHSA-r9hx-vwmv-q579-remove setuptools-65.5.0-py3-none-any.whl#866
Samruddhi Khandale (samruddhikhandale) merged 6 commits into
devcontainers:mainfrom
gauravsaini04:python_setuptools_65.5.0_GHSA-r9hx-vwmv-q579

Conversation

@gauravsaini04

@gauravsaini04 Gaurav Saini (gauravsaini04) commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

Feature name:

  • Python

Description:

This PR patches the following vulnerability:

Changelog:

  • Updated install.sh file

    • Replaced setuptools-65.5.0-py3-none-any.whl with setuptools-69.1.0-py3-none-any.whl
      • Downloaded setuptools source distribution;
      • Extracted and built from unzipped source distribution contents, the required file.
      • Updated __init__.py file inside ensurepip folder to have the corresponding correct version of setuptools.
  • Updated tests to verify that the vulnerable file setuptools-65.5.0-py3-none-any.whl no longer exists, which fixes GHSA-r9hx-vwmv-q579);

Checklist:

  • Checked that applied changes work as expected

@samruddhikhandale Samruddhi Khandale (samruddhikhandale) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool, thank you so much for taking a stab at fixing it

Comment thread src/python/install.sh Outdated
Comment thread src/python/install.sh Outdated
Comment thread src/python/install.sh
Comment thread src/python/install.sh Outdated
Comment thread src/python/install.sh Outdated
Comment thread test/python/install_python311_setuptools_vulnerability.sh Outdated
Comment thread src/python/install.sh Outdated
Comment thread src/python/install.sh Outdated
Comment thread test/python/install_python311_setuptools_vulnerability.sh Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me! Left one minor comment.

Comment thread test/python/scenarios.json
Comment thread src/python/install.sh Outdated
Comment thread test/python/scenarios.json

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants